Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Success, Error Images not Showing up #76

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

AyonAB
Copy link
Contributor

@AyonAB AyonAB commented Jan 16, 2020

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug Fix

⤵️ What is the current behavior?

Success and Error Images are not showing because they don't get included in the nuget package.

🆕 What is the new behavior (if this is a feature change)?

Success and Error Images are now showing up correctly.

💥 Does this PR introduce a breaking change?

Nope

🐛 Recommendations for testing

Build and publish a lcoal nuget package and try calling ShowSuccessWithStatus or ShowErrorWithStatus and check if images are showing up correctly.

📝 Links to relevant issues/docs

#64

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current develop

@Cheesebaron Cheesebaron merged commit ae513c2 into redth-org:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants